Fix sign-conversion warnings with musl ioctl#22
Closed
yktyagi wants to merge 1 commit intointel:masterfrom
Closed
Conversation
musl's ioctl request macros (_IOC) expand to unsigned long values, causing sign-conversion warnings when passed to ioctl() which expects an int as the request parameter. This issue occurs when building with -Werror -Wsign-conversion flags on musl-based systems, causing compilation failures. Cast the IOCTL_MEI_* macros explicitly to int in three locations: - IOCTL_MEI_CONNECT_CLIENT in __mei_connect() - IOCTL_MEI_CONNECT_CLIENT_VTAG in __mei_connect_vtag() - IOCTL_MEI_NOTIFY_GET in __mei_notify_get() This maintains compatibility with both glibc (where _IOC expands to int) and musl (where it expands to unsigned long). Signed-off-by: Yogesh Tyagi <yogesh.tyagi@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
musl's ioctl request macros (_IOC) expand to unsigned long values, causing sign-conversion warnings when passed to ioctl() which expects an int as the request parameter.
This issue occurs when building with -Werror -Wsign-conversion flags on musl-based systems, causing compilation failures.
Cast the IOCTL_MEI_* macros explicitly to int in three locations:
This maintains compatibility with both glibc (where _IOC expands to int) and musl (where it expands to unsigned long).